Release 0.3 - Bug Fix

For release 0.3 the bug I found to work on is https://github.com/devtools-html/debugger.html/issues/6048. The bug was, in the source tree pane on the left side, when you try to make a certain directory a root it would just take the original root directory and set that as the root not the one we select. Just like any other bug the very first thing to do is to try and recreate the bug. Well technically its to get the environment set up.  I didn't really have much trouble in setting up the environment. I just followed the instructions provided in the README.md and everything worked right off the start.
Also while I was in the step of recreating the bug, I only had to try it once and it was very clear that the bug existed. This is not the same for some other bugs that I encountered. The next task was to find out where in the code the bug existed.  This I did it by using the Debugger plug-in that was available in VScode. Using it to find the <div></div> tag that holds the attributes for what happens when the bug is trying to be replicated. This gave me access to the file where the function was being called to do the changes. This was the SourceTree.js file inside src/components/PrimaryPanes.

        menuOptions.push({
          id: "node-set-directory-root",
          label: setDirectoryRootLabel,
          accesskey: setDirectoryRootKey,
          disabled: false,
          click: () => this.props.setProjectDirectoryRoot(path)
        });

This was the piece of code where everything was being set. But the issue wasn't here, the issue was with how the app was reading the string that was being passed through as the path. So I looked at where the setProjectDirectoryRoot() function was being initialized. This led me to the ui.js file located in src/actions/. While reading through the code in this file I came across the piece of code that did this.

export function setProjectDirectoryRoot(newRoot: string) {
  return ({ dispatch, getState }: ThunkArgs) => {
    const curRoot = getProjectDirectoryRoot(getState());
    if (newRoot && curRoot) {
      const temp = newRoot.split("/");
      temp.splice(0, 2);
      newRoot = `${curRoot}/${temp.join("/")}`;
    }

    dispatch({
      type: "SET_PROJECT_DIRECTORY_ROOT",
      url: newRoot
    });
  };
}

This is clearly where the bug was and fixing it was fairly simple. I simple just changed the condition of the if statement and ran the code and the bug seemed to be fixed. With that done I sent a PR to the main repository where it awaits approval.

Comments

Post a Comment

Popular posts from this blog

Assignment 1 - DPS909

   For this assignment, our task was to use Google's libphonenumber library and create a RESTful api web service which would get the phone numbers from a string that is provided and also from a file that is provided.  The initial task was to determine what language we want to use to achieve the final result.  For me, I went with JavaScript, as I have worked with JavaScript before and would require less effort to achieve the result.  So for this assignment I used Node.js which is a JavaScript run-time environment which allows the execution of JavaScript code on the server-side. Dependencies used with Node.js express google-libphonenumber multer body-parser mocha chai chai-http nodemon     Express is a framework that allows the creation of web applications for Node.js.  This specific framework is the most standard framework for Node.js, which helped in making the decision rather simple.  I also used the google-libphonenumber package which uses the original libphone
Read more

Release 0.2 - Bug fix

   The bug I decided to fix for this release was a very quick and easy one.  It was to update the show more button.  It can be found here . It is not really a bug but it was a minor change that they wanted. Using devtools in the VSCode, it was very easy to figure out which file was the one that needed the change. It was in the  src/components/SecondaryPanes/CommandBar.css . The Line was changed to: mask : url ( / mc/command-chevron .svg ) no-repeat ; Since this was a fairly simple bug to fix, I went ahead and decided to learn more about how the project structure is. This would help me tremendously since I plan on working on the same project for the next release.
Read more

ECMA Script Testing

Image
For this lab we looked at the ECMAscript test suite. Setting it up and making it run was fairly simple and I didn't encounter any issues.  I just followed the steps provided in https://github.com/bterlson/test262-harness#test262-harness While running the tests not all of them pass. I thought this might have been a Windows issue. Therefore I tried it on my Linux machine and majority of it worked except 6. Then we looked at the test cases for Array.prototype.reverse().  For the task of this lab I simply just rewrote some new test cases to check the array.reverse.  This was fairly simple as looking at the other test cases it gave a general idea on how to write test cases for this. The test case I wrote can be found here. https://gist.github.com/pranoy10/10fd4bbf04a7490567d527017c8d52df
Read more